Implement Addons>ParseTime operator. #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @helinwang, first glance at the PR looks very good. Could you run |
|
Thanks @seanpmorgan ! Done. |
facaiy
requested changes
Sep 21, 2019
tensorflow_addons/custom_ops/text/cc/kernels/parse_time_kernel.cc
Outdated
Show resolved
Hide resolved
WindQAQ
reviewed
Sep 22, 2019
tensorflow_addons/custom_ops/text/cc/kernels/parse_time_kernel.cc
Outdated
Show resolved
Hide resolved
helinwang
force-pushed
the
master
branch
2 times, most recently
from
271d168 to
7f5a32f
Compare
helinwang
force-pushed
the
master
branch
2 times, most recently
from
d9fdaab to
99a897d
Compare
|
Thanks everyone, for the detailed review! All comments resolved. |
The parse time operator parses an input string according to the provided format string into a Unix time, the number of seconds / milliseconds / microseconds / nanoseconds elapsed since January 1, 1970 UTC. Fixes: tensorflow#492
|
@WindQAQ could you help add the "kokoro:force-run" tag again? I force pushed the commit again to fix a code style issue which failed the CI test. Thanks! |
|
@helinwang Please update readme and codeowner file when time allows :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parse time operator parses an input string according to the
provided format string into a Unix time, the number of seconds /
milliseconds / microseconds / nanoseconds elapsed since January 1,
1970 UTC.
Fixes: #492