check pass through and do the expand_dims() only if needed #464
Conversation
ChenYang-ChenYang
requested review from
guillaumekln and
qlzh727
as code owners
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
Could you check that you correctly signed the CLA? |
I login google with my gmail to sign, entering the github username ChenYang-ChenYang. But my github login email is not gmail and I think that's the problem. How to resolve this? I don't want to change my github account email and I think it makes sense to use non-gmail id for github. |
|
I think you can add multiple email address on github, @ChenYang-ChenYang |
Thanks for the suggestion. I added my email address to my github account just now. @guillaumekln please review. |
|
|
|
@ewilderj Hi, Edd, can you help reset cla status? Thanks! |
|
@googlebot rescan |
There was a problem hiding this comment.
Hi @ChenYang-ChenYang. It looks like the @googlebot does not want to help us at this time. Do you mind creating a new PR and considering the change below? Thanks.
The CLA issue has been resolved.
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
Looks good! @ChenYang-ChenYang Can you make sure that your email is setup correctly according to the CLA you signed? Thanks. |
…w#464) * check pass through and do the expand_dims() only if needed * add indent to the fixed line * merge return condition to if state
* Namespaced all of the custom ops * Updated C++ namespaces to not conflict w/ TF contrib ones * Ran code reformatting tool * Port bug fix in TF contrib to addons. (#497) * Port bug fix in TF contrib to addons. Original change at tensorflow/tensorflow@a913689. * Fix lint warning. * check pass through and do the expand_dims() only if needed (#464) * check pass through and do the expand_dims() only if needed * add indent to the fixed line * merge return condition to if state * add hardshrink kernel (#500) * add hardshrink kernel * make linter happy * Fixing SequenceLoss Keras incompatibility (#503) * Fix SequenceLoss incompatibility with Keras built-in loops * Remove debugging prints * Change the attribute existence checking to use more pythonic way * Replace some compat.v1 APIs by their v2 equivalent (#507) * Replace some compat.v1 APIs by their v2 equivalent * Fix lint error * Add documentation for LazyAdam (#515) * Updated hardshrink custom ops & made #ifdef names more consistent. * Fix to undef
7 participants
Add check before running tf.expand_dims(finished, axis=-1), or it will lead to input rank error. This is for issue #408 (comment)