Skip to content

Conversation

@facaiy
Copy link
Member

@facaiy facaiy commented Aug 29, 2019

It seems that autograph is not smart enough, so we have to control execute order by ourselves.

@facaiy facaiy requested a review from seanpmorgan as a code owner August 29, 2019 06:36
@facaiy facaiy requested review from a team and qlzh727 August 29, 2019 06:36
@facaiy
Copy link
Member Author

facaiy commented Aug 29, 2019

Following #453

@facaiy facaiy force-pushed the CLN/clean_code_weight_normal branch from e82c645 to e473b4b Compare August 29, 2019 07:40
@facaiy
Copy link
Member Author

facaiy commented Aug 29, 2019

The new implementation still performs slightly better than the regression model (but worser than the precious implementation). I don't know what's wrong

https://colab.research.google.com/drive/1yXMehUQdFQ0mFtgJjYaj6FBCp8fr4Dt8#scrollTo=r66OUUrK_l_S

@facaiy
Copy link
Member Author

facaiy commented Aug 29, 2019

I run it for five times, sometimes better, sometimes worser...

https://colab.research.google.com/drive/1yXMehUQdFQ0mFtgJjYaj6FBCp8fr4Dt8#scrollTo=UZd6V90eR4Gm

@seanpmorgan
Copy link
Member

seanpmorgan commented Aug 29, 2019

@facaiy I think it was for the wrong reason that it always outperformed using the previous version (at least through a very small number of epochs). Could you try to increase the number of epochs a significant amount? Also mind making the colab sharable?

@facaiy
Copy link
Member Author

facaiy commented Aug 29, 2019

Oh, my fault. I make it sharable now, please check the link: https://colab.research.google.com/drive/1yXMehUQdFQ0mFtgJjYaj6FBCp8fr4Dt8

Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@WindQAQ WindQAQ merged commit 7e0f343 into tensorflow:master Aug 29, 2019
@facaiy facaiy deleted the CLN/clean_code_weight_normal branch August 29, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants