Skip to content

Conversation

@WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Aug 15, 2019

Closes #407. Since AttentionWrapper is also a subclass of Layer and indeed does something. So this PR makes it able to takes **kwargs while calling __init__().

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @WindQAQ !

@seanpmorgan seanpmorgan merged commit 556641c into tensorflow:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attention wrapper tests fail for float64 dtype

3 participants