Connected components PR

[sayoojbk]

I have ported most of the code to tf 2.0 but for some reasons the tests are not running on my system.

[WindQAQ]

Hello, @sayoojbk, thanks for the contribution! Please do some changes according to comments down below. Also, it would be great to run tests locally first especially for cpp kernel part. You know... it is hard to be a human compiler haha. Thanks!

[WindQAQ]

LGTM. I think we could rename connected_ops.py to either connected_components_ops.py or segmentation_ops.py, so does connected_ops_test.py.

[sayoojbk]

LGTM. I think we could rename connected_ops.py to either connected_components_ops.py or segmentation_ops.py, so does connected_ops_test.py.

Ya was about to ask you about that. In the TensorFlow contrib module this was named as segmentation_ops but since the naming convention of connnected_components made more sense so thought could name it connected_component_ops.py but there also while function calling in the connected_components_ops_test.py the calling of the function namely connected_components.connected_components seems a bit out of a good naming convention manner and connected_ops.connected_components seemed better. Just let me know whichever naming convention seems better and will soon make that changes.

[WindQAQ]

As you say, could we call it connected_components.py? And in __init__.py, import it like

from tensorflow_addons.image.connected_components import connected_components

So in the testing file connected_components_test.py, you could import it via

from tensorflow_addons.image import connected_components

and can use it directly

connected_components(image)

[sayoojbk]

As you say, could we call it connected_components.py? And in __init__.py, import it like

from tensorflow_addons.image.connected_components import connected_components

So in the testing file connected_components_test.py, you could import it via

from tensorflow_addons.image import connected_components

and can use it directly

connected_components(image)

Ya, but when the function has to be called for example like this:
self.assertAllEqual(self.evaluate( connected_components.connected_components(arr)), expected)
seems a bit odd. Then maybe I could just call the function in the connected_components_test.py as

from tensorflow_addons.image.connected_components import connected_components

[WindQAQ]

Go ahead :P Don't forget to run sanity check locally

[sayoojbk]

Go ahead :P Don't forget to run sanity check locally

Ya, my bad :P Will do all the checks and let you know when it's ready for merging!

[sayoojbk]

Hey, @WindQAQ I guess I have made most of the changes suggested by you and ran all the tests and all have passed. It looks ready to be merged to the main branch

[WindQAQ]

Great! Thanks for the contribution again!