[image/distort_image_ops] fix graph mode tests #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The sanity check also failed due to timeout... |
feihugis
reviewed
Aug 5, 2019
| delta_h = np.random.rand() * 2.0 - 1.0 | ||
| with self.assertRaisesOpError("input must have 3 channels " | ||
| "but instead has 4 channels"): | ||
| with self.assertRaisesRegex(ValueError, msg): |
Member
There was a problem hiding this comment.
I did not figure out why the check failure here is not raised in the graph mode in the GPU version of tensorflow-2.0-preview, but it is raised in the CPU version.
Member
Author
There was a problem hiding this comment.
I also have no idea about it... I'd suppose it should either fail or pass regardless of the device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373.
This is probably related to #12 and tensorflow/tensorflow#24945 (in the totally opposite side). I think the best solution now is to do shape inference in SetShapeFn while registering OP, which seems to successfully raise the same exception (ValueError) and the same error message in both graph and eager modes.