Skip to content

Cleanup score_mask_value definition #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2019
Merged

Cleanup score_mask_value definition #352

merged 1 commit into from
Jul 23, 2019

Conversation

@guillaumekln
Copy link
Contributor

@guillaumekln guillaumekln commented Jul 15, 2019

No description provided.

@guillaumekln guillaumekln requested a review from qlzh727 as a code owner July 15, 2019 08:10
qlzh727
qlzh727 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, can u fix the sanity check error?

@guillaumekln
Copy link
Contributor Author

guillaumekln commented Jul 17, 2019

As it's unrelated to this change, I fixed it in #354. Once #354 is merged, we can rebase and merge.

@seanpmorgan
Copy link
Member

seanpmorgan commented Jul 23, 2019

Sanity check was fixed in another PR. Thanks for the contribution!

@seanpmorgan seanpmorgan merged commit a8316c7 into tensorflow:master Jul 23, 2019
@guillaumekln guillaumekln deleted the cleanup-score-mask-value branch July 29, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qlzh727 qlzh727 qlzh727 approved these changes

Assignees

No one assigned

Labels

cla: yes seq2seq

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@guillaumekln @seanpmorgan @qlzh727 @googlebot @WindQAQ @Squadrick @kokoro-team