Skip to content

Conversation

@WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Jun 20, 2019

Addresses #26. Will proceed with multilabel npairs loss after this.

@WindQAQ WindQAQ added the losses label Jun 20, 2019
@WindQAQ WindQAQ requested a review from a team June 20, 2019 07:00
@WindQAQ WindQAQ requested a review from facaiy as a code owner June 20, 2019 07:00
@WindQAQ WindQAQ removed the request for review from facaiy June 20, 2019 07:01
Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes.

Copy link
Member

@Squadrick Squadrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM.

@Squadrick Squadrick merged commit 7a1ed4b into tensorflow:master Jun 21, 2019
@WindQAQ WindQAQ deleted the migrate-npairs-loss branch June 21, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants