Skip to content

Fix shape checking #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2019
Merged

Fix shape checking #290

merged 1 commit into from
Jun 15, 2019

Conversation

@WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Jun 15, 2019

Closes #260.

@WindQAQ WindQAQ requested a review from a team June 15, 2019 10:35
@WindQAQ WindQAQ added the image label Jun 15, 2019
seanpmorgan
seanpmorgan approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WindQAQ. This look great.

@seanpmorgan seanpmorgan merged commit 320ad67 into tensorflow:master Jun 15, 2019
@WindQAQ WindQAQ deleted the fix-shape-checking branch June 15, 2019 16:24
@kyleabeauchamp kyleabeauchamp mentioned this pull request Jun 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

Assignees

No one assigned

Labels

cla: yes image

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Raise exceptions based on tensor's properties

3 participants

@WindQAQ @seanpmorgan @googlebot