-
Notifications
You must be signed in to change notification settings - Fork 617
Support batch input for median_filter2d #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batch input for median_filter2d #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
|
@Mainak431 Hi, would you mind taking a look? |
|
@WindQAQ Thanks for the excellent contribution. Everything looks pretty fine. |
|
@Mainak431 Here is the example colab notebook. I will include this in addon's example in maybe the next PR. |
|
Nice contribution.
…On Sun 16 Jun, 2019, 10:20 PM Tzu-Wei Sung, ***@***.***> wrote:
@Mainak431 <https://github.com/Mainak431> Here is the example colab
notebook
<https://colab.research.google.com/drive/1ZOAFTRdxKYDBpG75ZITukIr8MjUR2qDA>.
I will include this in addon's example in maybe the next PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#288?email_source=notifications&email_token=AIRDMQVU3QCXZFC6XXLN4STP2ZVPDA5CNFSM4HYLJF6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZQ3MI#issuecomment-502468017>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIRDMQT2RQ7ED3MIX6IELALP2ZVPDANCNFSM4HYLJF6A>
.
|
|
@WindQAQ Thanks for the contribution. |
Addresses #230. Also meets the interface of mean_filter2d.
A general random test case is down below. Maybe there are some ways to speed up. It's now much more slower than scipy's implementation even for the input of shape [1, h, w, 1].
https://colab.research.google.com/drive/1UkNXxjTMHifKmHB2N5ojOHFojtXrOUIG