Skip to content

Conversation

@WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Jun 14, 2019

Addresses #230. Also meets the interface of mean_filter2d.

A general random test case is down below. Maybe there are some ways to speed up. It's now much more slower than scipy's implementation even for the input of shape [1, h, w, 1].
https://colab.research.google.com/drive/1UkNXxjTMHifKmHB2N5ojOHFojtXrOUIG

@WindQAQ WindQAQ requested a review from a team June 14, 2019 17:40
@WindQAQ WindQAQ added the image label Jun 14, 2019
Copy link
Member

@facaiy facaiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@facaiy
Copy link
Member

facaiy commented Jun 16, 2019

@Mainak431 Hi, would you mind taking a look?

@Mainak431
Copy link
Contributor

@WindQAQ Thanks for the excellent contribution. Everything looks pretty fine.
Can you please add a small training example using this layer with a conv2d layer and dropout layer in tensorflow with maybe mnist dataset? So, that it can be directly used in the network itself?

@WindQAQ
Copy link
Member Author

WindQAQ commented Jun 16, 2019

@Mainak431 Here is the example colab notebook. I will include this in addon's example in maybe the next PR.

@Mainak431
Copy link
Contributor

Mainak431 commented Jun 16, 2019 via email

@Squadrick Squadrick merged commit 894a074 into tensorflow:master Jun 16, 2019
@Squadrick
Copy link
Member

@WindQAQ Thanks for the contribution.

@WindQAQ WindQAQ deleted the batch-input-for-median-filter2d branch June 16, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants