Skip to content

Build with TF 2.11.0 #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 9, 2022
Merged

Build with TF 2.11.0 #2782

merged 10 commits into from
Dec 9, 2022

Conversation

bhack
Copy link
Contributor

@bhack bhack commented Nov 22, 2022

Build the release with TF 2.11.0

@boring-cyborg boring-cyborg bot added the github label Nov 22, 2022
@bhack bhack requested a review from seanpmorgan November 22, 2022 16:15
@bhack
Copy link
Contributor Author

bhack commented Nov 22, 2022 •
edited
Loading

@chenmoneygithub Can you check the optimizers 2.11 errors?

@chenmoneygithub
Copy link
Contributor

@bhack I made #2783 to fix optimizer failures. The error log is too long to read, so I might miss some cases.

@AakashKumarNain
Copy link
Member

We need to remove GroupNormalization layer as it has been incorporated in the core now

@bhack
Copy link
Contributor Author

bhack commented Nov 23, 2022 •
edited
Loading

We need to remove GroupNormalization layer as it has been incorporated in the core now

Yes but I think that we need to give the same deprecation warning like other "duplicated" components. Can you send a PR against build_2.11.0 branch?

@AakashKumarNain
Copy link
Member

We need to remove GroupNormalization layer as it has been incorporated in the core now

Yes but I think that we need to give the same deprecation warning like other "duplicated" components. Can you send a PR against build_2.11.0 branch?

I can do it over the weekend. Got a lot on my plate right now. Will that work?

@bhack
Copy link
Contributor Author

bhack commented Nov 23, 2022

I can do it over the weekend. Got a lot on my plate right now. Will that work?

Yes it is ok as we are waiting also for the Macos release https://pypi.org/project/tensorflow-macos/#history

seanpmorgan
seanpmorgan reviewed Dec 6, 2022
View reviewed changes
.github/workflows/release.yml Outdated
os: ['macOS', 'Windows', 'Linux']
py-version: ['3.7', '3.8', '3.9', '3.10']
tf-version: ['2.10.0']
tf-version: ['2.9.3', '2.10.1', '2.11.0']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only publish wheels that were built with the most recent TF version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we had some drift with https://github.com/tensorflow/addons/blob/master/tools/update_release_version.sh.
I think that we could fix that utility that I've contributed as it is still useful to quickly prepare a release version PR for the "repetitive" tasks.

seanpmorgan
seanpmorgan approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all your work! We're approaching a month since release. I think we may need to drop the tensorflow-macos dependency after that.

@bhack
Copy link
Contributor Author

bhack commented Dec 6, 2022

LGTM, thanks for all your work! We're approaching a month since release. I think we may need to drop the tensorflow-macos dependency after that.

@kulinseth do you have any news to share?

@bhack bhack mentioned this pull request Dec 7, 2022
Closed
@kulinseth
Copy link

LGTM, thanks for all your work! We're approaching a month since release. I think we may need to drop the tensorflow-macos dependency after that.

@kulinseth do you have any news to share?

I will update here soon with the release. We are doing final round of testing.

@bhack bhack linked an issue Dec 8, 2022 that may be closed by this pull request
TF 2.11 support release? #2788
Closed
@seanpmorgan seanpmorgan merged commit c80423a into master Dec 9, 2022
@seanpmorgan seanpmorgan deleted the build_2.11.0 branch October 17, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@AakashKumarNain AakashKumarNain Awaiting requested review from AakashKumarNain

@fsx950223 fsx950223 Awaiting requested review from fsx950223

Assignees

No one assigned

Labels

github metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TF 2.11 support release?

5 participants

@bhack @chenmoneygithub @AakashKumarNain @kulinseth @seanpmorgan