Skip to content

Support for macOS Monterey #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Support for macOS Monterey #2615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7232350
Update .bazelversion
yarri-oss Dec 1, 2021
eb6cba4
Update build_pip_pkg.sh
yarri-oss Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelversion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.7.2
4.2.1
Copy link
Contributor

@bhack bhack Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any side effect about diverging version from https://github.com/tensorflow/tensorflow/blob/master/.bazelversion ?

Copy link
Author

@yarri-oss yarri-oss Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially, and if so this might justify a new approach to handle macOS TFA builds perhaps with a macos_m1 branch.

Created an issue to continue the discussion here: #2616

Copy link
Contributor

@bhack bhack Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't have a new rollback we are at 4.2.1 in https://github.com/tensorflow/tensorflow/blob/master/.bazelversion

2 changes: 1 addition & 1 deletion build_deps/build_pip_pkg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function main() {
BUILD_CMD="setup.py bdist_wheel --platlib-patch"
if is_macos; then
if [[ x"$(arch)" == x"arm64" ]]; then
BUILD_CMD="${BUILD_CMD} --plat-name macosx_11_0_arm64"
BUILD_CMD="${BUILD_CMD} --plat-name macosx_12_0_arm64"
Copy link
Contributor

@bhack bhack Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not going to distribute macosx_11 packages anymore?

I see that tensorflow-macosx wheels are still on macosx_11_0:
https://pypi.org/project/tensorflow-macos/2.6.0/#files

Copy link
Author

@yarri-oss yarri-oss Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is build from source issue, so only local wheel files. We seem to have only a minimal macOS version support, but if I understand the platform correctly, we may need to change the build_pip_pkg.sh file to instead check for either x86 or M1 and OS version.

Copy link
Contributor

@bhack bhack Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is only local as we are using the same in Action:

https://github.com/tensorflow/addons/blob/master/.github/workflows/make_wheel_macOS_arm64.sh#L27

addons/BUILD

Line 3 in 41eaa27

srcs = ["build_deps/build_pip_pkg.sh"],

else
BUILD_CMD="${BUILD_CMD} --plat-name macosx_10_13_x86_64"
fi
Expand Down