-
Notifications
You must be signed in to change notification settings - Fork 617
Fix distort_image_ops_test #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix distort_image_ops_test #257
Conversation
|
Is there a nightly build link or something that shows the failure? I trust you, but for the sake of reproducibility might be nice to have some sort of link to the exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks! |
|
Shape checking within Btw, thanks for asking and review, Kyle 😄 |
|
Thanks for the fix! Just trying to understand what happend here... typically the RegEx is supposed to catch the error thrown by this I believe: But at first pass I can't find the commit that affected this. LGTM to merge if @facaiy is good with it.. but I think something has changed with shape checking in our op? |
|
One option would be to merge this fix and create a separate issue to look into why this happend. |
Thank you, Sean! The original regex text and the type of exception seem wrong while the test passed previously... addons/tensorflow_addons/custom_ops/image/cc/kernels/adjust_hsv_in_yiq_op.cc Lines 57 to 59 in d46dba1
Anyway, because the tests fail randomly, I will create an issue for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.. discussion of how this should be done can be solved in #260
Fix failed builds because of update in upstream.