Skip to content

FIX: Remove epsilon as variable. #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2019
Merged

FIX: Remove epsilon as variable. #248

merged 2 commits into from
May 17, 2019

Conversation

@facaiy
Copy link
Member

@facaiy facaiy commented May 17, 2019

Fix #246

@facaiy facaiy requested a review from WindQAQ as a code owner May 17, 2019 00:24
@facaiy facaiy requested a review from seanpmorgan May 17, 2019 00:45
@facaiy facaiy self-assigned this May 17, 2019
@kyleabeauchamp
Copy link
Contributor

kyleabeauchamp commented May 17, 2019

LGTM

@WindQAQ WindQAQ merged commit d1c1abb into tensorflow:master May 17, 2019
@facaiy facaiy deleted the ENH/use_epsilon_as_constant branch May 18, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WindQAQ WindQAQ WindQAQ approved these changes

@seanpmorgan seanpmorgan Awaiting requested review from seanpmorgan

+1 more reviewer

@kyleabeauchamp kyleabeauchamp kyleabeauchamp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@facaiy facaiy

Labels

cla: yes optimizers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build fails because of optimizers

4 participants

@facaiy @kyleabeauchamp @WindQAQ @googlebot