Add metrics module #247
Merged
Add metrics module #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good, I'll also ask @seanpmorgan or @WindQAQ if they have any concerns about this change? Then let's merge it :-) |
Member
Author
No worries |
Member
|
LSTM! Remember to merge the latest commit so that the builds could pass. |
seanpmorgan
requested changes
May 18, 2019
facaiy
reviewed
May 18, 2019
facaiy
reviewed
May 18, 2019
facaiy
reviewed
May 18, 2019
facaiy
reviewed
May 18, 2019
…d_metrics add new changes
… into add_metrics update changes
facaiy
approved these changes
May 18, 2019
Member
|
Thank you, Aakash. @seanpmorgan Sean, can you take an another look? |
Member
Author
|
Perfect. You are welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
metricsmodule to add metrics that conform to thetf.keras API.