-
Notifications
You must be signed in to change notification settings - Fork 617
Moved build_docs.py and BUILD into /tools/docs/ #2167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
seanpmorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion in #2161 please update the documentation in this PR
Regarding that I had doubt, Shall I completely remove the documentation related with build_docs.py in docs/ and make a new documentation in tools/docs/ like it was in docs/ ? |
|
Update |
WindQAQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for contribution! We also have to modify this line
https://github.com/tensorflow/addons/blob/master/tools/docker/sanity_check.Dockerfile#L97 to
RUN python tools/docs/build_docs.py
| deps = [ | ||
| "//tensorflow_addons", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on it. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WindQAQ please review the PR
WindQAQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Moved build_docs.py and BUILD into /tools/docs/ * Modified paths in documentation * removing build_docs.py from BUILD * updating to bazel code format * Revert "updating to bazel code format" This reverts commit f97c2ad. * Revert "removing build_docs.py from BUILD" This reverts commit 3967d14. * Updated sanity_check.dockerfile with new path
Description
Brief Description of the PR:
To supplement the changes made in the location of files in docs/ to /tools/docs/
Fixes #2161
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*