Added filtered_input and constrained_decoding #2166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes tensorflow#607 We can have a common function for creating filtered_inputs used in crf_multitag_sequence_score This function can be reused to modify the input to crf_decode to support constrained decoding.
Contributor
Author
|
@facaiy @Squadrick @seanpmorgan can you have a look at it? |
WindQAQ
reviewed
Sep 16, 2020
Member
WindQAQ
left a comment
WindQAQ
left a comment
There was a problem hiding this comment.
LGTM! One minor documentation issue.
Member
|
@napsternxg Can you run the formatting tools again? I'd like to merge this after the tests pass. Thank you! |
Contributor
Author
|
@WindQAQ Fixed it. |
Contributor
Author
|
@Squadrick was removed by mistake when I clicked on request review. |
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Added filtered_input and constrained_decoding - Fixes tensorflow#607 We can have a common function for creating filtered_inputs used in crf_multitag_sequence_score This function can be reused to modify the input to crf_decode to support constrained decoding. * Fixed formatting and imports * Fixed documentation * Fixed formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
We can have a common function for creating filtered_inputs used in
crf_multitag_sequence_scoreThis function can be reused to modify the input to
crf_decodeto support constrained decoding.Fixes #607
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes: