Skip to content

Conversation

@Harsh188
Copy link
Contributor

@Harsh188 Harsh188 commented Aug 30, 2020

Description

Adding testable docstrings to losses.
Fixes #2066

Changes made to:

  • quantiles.py
  • npairs.py
  • kappa_loss.py
  • giou_loss.py
  • focal_loss.py
  • contrastive.py

Type of change

  • Updated or additional documentation

Checklist:

How Has This Been Tested?

  • Used pylint with TensorFlow's custom style definition

@bot-of-gabrieldemarmiesse

@SSaishruthi @RomainBrault @wenmin-wu @fsx950223 @AakashKumarNain

You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@Harsh188 Harsh188 changed the title [WIP]#2066 doctest update losses #2066 doctest update losses Aug 30, 2020
@Harsh188
Copy link
Contributor Author

Looks like the checks are failing because I forgot to run cd .git/hooks && ln -s -f ../../tools/pre-commit.sh pre-commit before commiting my files. Please let me know how to fix this.

@seanpmorgan
Copy link
Member

Looks like the checks are failing because I forgot to run cd .git/hooks && ln -s -f ../../tools/pre-commit.sh pre-commit before commiting my files. Please let me know how to fix this.

No worries. Just run that command now from your branch and commit the formatted changes.

bhack
bhack previously approved these changes Sep 2, 2020
@WindQAQ WindQAQ merged commit d466cb8 into tensorflow:master Sep 4, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* updated contrastive.py

* updated focal_loss.py

* updated giou_loss.py

* updated kappa_loss.py

* updated npairs.py

* updated quantiles.py

* reformatting giou_loss.py

* updated testable docs contrastive.py

* updated doctests focal_loss.py

* updated testdocs giou_loss.py

* updated testdocs kappa_loss.py

* updated testdocs npairs.py

* updated testdocs quantiles.py

* minor changes to formatting

* fixing multi-line error

* adding empty line inbetween imports

* adding empty line inbetween imports

* reformatting imports

* reverting code formatting changes

* reformatting imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testable docstrings

6 participants