Skip to content

Fix broken link in NovoGrad docstring #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2020
Merged

Fix broken link in NovoGrad docstring #2096

merged 4 commits into from
Aug 16, 2020

Conversation

@seungjaeryanlee
Copy link
Contributor

@seungjaeryanlee seungjaeryanlee commented Aug 15, 2020

Description

This PR fixes stylistic issues in the NovoGrad optimizer documentation page.

Fixes #2085

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@bot-of-gabrieldemarmiesse
Copy link

bot-of-gabrieldemarmiesse commented Aug 15, 2020

@shreyashpatodia

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@seungjaeryanlee seungjaeryanlee changed the title Fix novograd docstring Fix broken link in NovoGrad docstring Aug 15, 2020
0xshreyash
0xshreyash previously approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@0xshreyash 0xshreyash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

WindQAQ
WindQAQ reviewed Aug 16, 2020
View reviewed changes
@WindQAQ WindQAQ self-requested a review August 16, 2020 15:32
WindQAQ
WindQAQ approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@WindQAQ WindQAQ merged commit c083f28 into tensorflow:master Aug 16, 2020
@seungjaeryanlee seungjaeryanlee deleted the fix-novograd-docstring branch August 16, 2020 15:46
@bot-of-gabrieldemarmiesse bot-of-gabrieldemarmiesse mentioned this pull request Aug 27, 2020
Merged
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@seungjaeryanlee
Fix broken link in NovoGrad docstring (tensorflow#2096)
1d33305 
* Fix broken link in NovoGrad docstring

* Fix typo in NovoGrad paper title

* Add missing parenthesis

* Remove unneeded wordy phrase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WindQAQ WindQAQ WindQAQ approved these changes

+1 more reviewer

@0xshreyash 0xshreyash 0xshreyash left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport r0.11 cla: yes optimizers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Markdown parsing error in NovoGrad documentation page

6 participants

@seungjaeryanlee @bot-of-gabrieldemarmiesse @WindQAQ @0xshreyash @googlebot @seanpmorgan