Skip to content

Conversation

@WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Jul 27, 2020

Description

Brief Description of the PR:

tensorflow/tensorflow#41178 got merged today (7/27). I suppose it won't appear in TensorFlow 2.3.* unless it's cherry-picked by someone.
@seanpmorgan Can we do that or ask someone to do that or just wait for next release? Thank you.

Fixes #2005.

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:

  • Just add deprecation warnings

@WindQAQ WindQAQ requested a review from a team July 27, 2020 18:01
@WindQAQ WindQAQ requested a review from AakashKumarNain as a code owner July 27, 2020 18:01
@WindQAQ WindQAQ changed the title Activations/deprecate gelu Deprecate gelu Jul 27, 2020
@bot-of-gabrieldemarmiesse

@AakashKumarNain

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@bhack
Copy link
Contributor

bhack commented Jul 27, 2020

@bhack
Copy link
Contributor

bhack commented Jul 27, 2020

In the meantime tensorflow/models#8977

@bhack
Copy link
Contributor

bhack commented Jul 27, 2020

Are we going to deprecate also GELU codeowners?

@AakashKumarNain
Copy link
Member

I am wondering how will the contribution be counted in this case.

@seanpmorgan seanpmorgan merged commit 40e406d into tensorflow:master Aug 3, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* Deprecate gelu
* Add DeprecationWarning for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate GELU

6 participants