Skip to content

FIX: build using tf sysconfig #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 22, 2019
Merged

FIX: build using tf sysconfig #197

merged 7 commits into from
Apr 22, 2019

Conversation

@seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Apr 21, 2019

This will make the lookup of shared library name OS agnostic.

@seanpmorgan seanpmorgan requested a review from a team as a code owner April 21, 2019 23:09
@seanpmorgan seanpmorgan changed the title Fix build using tf sysconfig FIX: build using tf sysconfig Apr 21, 2019
facaiy
facaiy previously approved these changes Apr 22, 2019
View reviewed changes
@facaiy @seanpmorgan
Update README.md
f0b98c4 
Co-Authored-By: seanpmorgan <[email protected]>
@googlebot
Copy link

googlebot commented Apr 22, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

facaiy and others added 3 commits April 22, 2019 05:15
@facaiy @seanpmorgan
Update README.md
f2c7e79 
Co-Authored-By: seanpmorgan <[email protected]>
@seanpmorgan
Standardize naming
dd5ef8e
@seanpmorgan
Merge remote-tracking branch 'origin/fix-build-using-tf-sysconfig' in…
dbbfb3f 
…to fix-build-using-tf-sysconfig

# Conflicts:
#	tf_dependency/tf_configure.bzl
@seanpmorgan seanpmorgan merged commit a9ee66a into tensorflow:master Apr 22, 2019
@seanpmorgan seanpmorgan deleted the fix-build-using-tf-sysconfig branch April 22, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facaiy facaiy facaiy left review comments

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seanpmorgan @googlebot @facaiy