Add subpackage for RNN related code. #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The test case was missing test.main, which means the test wasn't executed at all. 2. Add initializer params for user to control how weights are initialized. 3. Update the tests with the fix.
seanpmorgan
changed the title
seanpmorgan
requested changes
Apr 18, 2019
Member
seanpmorgan
left a comment
seanpmorgan
left a comment
There was a problem hiding this comment.
Code looks very good and this is a nice addition to the repo. Some things need to be added though:
- Please import rnn in the global init
- Add rnn to the packaging BUILD file
- Add the subpackage to the project REAMDE
- Add a subpackage README describing the API style for RNN (inherit from keras.AbstractCell etc.)
1. Update the addon init/build/README 2. Add README for rnn.
Member
Author
|
Done. Thanks for the review. Btw, the build seems broken due to the recent release of tf estimator. |
seanpmorgan
reviewed
Apr 18, 2019
seanpmorgan
requested changes
Apr 18, 2019
Member
seanpmorgan
left a comment
seanpmorgan
left a comment
There was a problem hiding this comment.
Thanks! One small nit comment and then could you also modify .github/CODEOWNERS. I really like the explicit criteria for being accepted. This might be something we should apply to more subpackages. Thoughts @facaiy ?
Small changes and then we can merge this after our CI returns tomorrow.
Member
Author
|
Done. Updated doc and gitowner file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly bring over the tf.contrib.rnn code to addons.
The selection criteria so far are:
The initial commit only contains one rnn cell so far (NASCell), expect more cells to come.