Skip to content

Conversation

@seanpmorgan
Copy link
Member

Closes #138

Removing the decorator is not ideal, but stability is more important than the speed up we'd get with that decorator. @WindQAQ are these changes okay with you?

@seanpmorgan seanpmorgan changed the title Use public API for name_scope and convert_to_tensor Fix Dense Image Warp Bug Apr 17, 2019
@seanpmorgan seanpmorgan assigned facaiy and unassigned facaiy Apr 17, 2019
@seanpmorgan seanpmorgan requested a review from facaiy April 17, 2019 20:26
@seanpmorgan seanpmorgan changed the title Fix Dense Image Warp Bug FIX: Dense Image Warp Bug Apr 17, 2019
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll still keep track on it. Thank you!

@facaiy facaiy merged commit 8bab322 into tensorflow:master Apr 18, 2019
@seanpmorgan seanpmorgan deleted the fix-densewarp branch April 18, 2019 12:37
@khatchad
Copy link

Closes #138

Removing the decorator is not ideal, but stability is more important than the speed up we'd get with that decorator. @WindQAQ are these changes okay with you?

I think you can keep both. Please see my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dense Image Warp tests are flaky

5 participants