-
Notifications
You must be signed in to change notification settings - Fork 617
fix #1824 #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1824 #1840
Conversation
|
Does |
|
@fsx950223 Do you have a minimal code to reproduce #1824? Edit: I am a little bit worried about "sometimes miss.." |
|
Since Dataset runs map function in Graph mode. I won't add a test code. |
|
Yes I saw that his squeeze example the Tensor shape misses. |
It won't change anything. |
This why I asked to you before what do you mean with "sometimes". |
We don't support 3D and 2D images after we discussed at #1338 (comment) and data_format too. |
|
How do you process images with batch_size>1 without set shape again? |
|
Ok for 3D and 2D images I've not followed that review but just the new thread at #1825 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. I believe this is a right fix so I am going to merge this first. Let's open other issues for further discussion. Thank you all!
Sometimes miss Tensor shape in Graph mode.
Set shape explicitly.