Added tests for the time stopping callback #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpmorgan
approved these changes
Apr 5, 2020
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Added tests for time stopping. * Small refactoring. * Rename. * Refactoring. * Calming the angry bazel. * Added the dependency to optimizers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1501
cc @failure-to-thrive
This should work even if there are weird things happening to the thread.
The tests take 7s to run. Due to the nature of the tests, I couldn't make them any faster.