-
Notifications
You must be signed in to change notification settings - Fork 617
Add a warning when trying to load a custom op with a uncompatible version of TF. #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seanpmorgan
merged 7 commits into
tensorflow:master
from
gabrieldemarmiesse:add_warnings
Apr 2, 2020
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b69bc8d
Fixing the gpu build.
gabrieldemarmiesse b2f77c4
Add a warning when trying to load a custom op.
gabrieldemarmiesse 1073f69
Add also the nightly version.
gabrieldemarmiesse c6016f5
Better formatting.
gabrieldemarmiesse 7668b0f
Update message.
gabrieldemarmiesse bc455e3
Merge branch 'master' into add_warnings
gabrieldemarmiesse 983607c
Added message about non-pip TF.
gabrieldemarmiesse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add "installed from pip" somewhere in there. I suspect that is just as likely of an issue as incompatible version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it. But this warning won't appear if someone is building from source. I don't know if there is any way we can detect that. If TF was exposing an API to get info about the build, we could use that. As far as I know, such an API doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so. If there was it would be in https://www.tensorflow.org/api_docs/python/tf/sysconfig most likely