[bugfix] unit test on mac #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Mac OS X system due to cannot get CPU core number correctly. this commit fix it.
armando-fandango
approved these changes
Apr 4, 2019
Member
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addons_cpu.sh cannot work correctly on Mac OS X system due to cannot get CPU core number correctly. this PR fix it.
Also, related with #77 , I build and unit test tensorflow-addons on Mac based on commit a3fd8ef (not the master branch which is CI test failed when I write this PR): building is OK and unit test passed.
As a reminder for other developers on Mac, due to the issue bazelbuild/bazel#7241 with bazel, developers should not using virtualenv to test addons on Mac for now.