Skip to content

Conversation

joel-shor
Copy link
Contributor

@joel-shor joel-shor commented Mar 7, 2020

Add a layer. Layer description is in the Python class description.

@boring-cyborg boring-cyborg bot added the github label Mar 7, 2020
@joel-shor
Copy link
Contributor Author

seanpmorgan and facaiy, this is ready for review now

@joel-shor
Copy link
Contributor Author

@seanpmorgan @facaiy

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Almost LGTM

@joel-shor
Copy link
Contributor Author

@seanpmorgan I finished all your suggestions but one, which I think I addressed in spirit but not exactly what you asked for. Please check that it's sufficient

@joel-shor
Copy link
Contributor Author

@seanpmorgan done and ready. thanks!

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@seanpmorgan seanpmorgan merged commit e65f79e into tensorflow:master Mar 9, 2020
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
* Add NetVLAD layer to TF add-ons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants