Added prompt before install #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Before merging this I just want to make sure that our CI scripts will not break here. @facaiy it looks like we already pass |
Member
|
Thank you for the change, @shreyashub ! @seanpmorgan Sean, I'll take a look at weekend :-) |
Member
Yes, addons/tools/ci_testing/addons_cpu.sh Line 45 in 83195c9 |
Member
|
@shreyashub Hi, Shreyas, apologized for the delay. We'll handle the PR as soon as possible, thank you for your patience :-) |
seanpmorgan
approved these changes
Apr 17, 2019
Member
seanpmorgan
left a comment
seanpmorgan
left a comment
There was a problem hiding this comment.
Thanks for your help @shreyashub !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #117. Added yes/no prompt in
configure.sh