Test wheels in a fresh environement #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldemarmiesse
changed the title
seanpmorgan
requested changes
Mar 3, 2020
.github/workflows/release.yml
Outdated
| run: | | ||
| pip install tensorflow~=2.1.0 | ||
| pip install wheel/tensorflow_addons-*.whl | ||
| python -c "import tensorflow_addons as tfa; print(tfa.activations.gelu(0.2))" |
There was a problem hiding this comment.
Since gelu is a possible candidate for moving to TF core. Could we replace with another custom-op? Say gather_tree As seq2seq is likely to stay in Addons for the foreseeable future.
There was a problem hiding this comment.
I used lisht because it's simpler to setup than gather_tree.
There was a problem hiding this comment.
Thanks, I'm good with that. Depending on results of #1156 lisht custom-op may be removed at some point so lets just keep that in mind as those results get reported.
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Test macos and windows wheels. * Add widnows. * Test all wheels. * Depends on result of tests. * Change name. * Use matrix everywhere. * Replaced gelu by lisht.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1122