Skip to content

Removed erroneous scale_fn from CLR subclasses #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2020
Merged

Removed erroneous scale_fn from CLR subclasses #1160

merged 2 commits into from
Feb 28, 2020

Conversation

lcsfrey
Copy link
Contributor

@lcsfrey lcsfrey commented Feb 27, 2020

The current CyclicalLearningRate subclasses (TriangularCyclicalLearningRate, Triangular2CyclicalLearningRate, and ExponentialCyclicalLearningRate) are responsible for generating their own scale_fn. So they should not have scale_fn in their function arguments.

@lcsfrey lcsfrey mentioned this pull request Feb 27, 2020
Closed
@seanpmorgan seanpmorgan added the backport r0.8 Will backport any PR merged with this label to the r0.8 branch label Feb 27, 2020
seanpmorgan
seanpmorgan requested changes Feb 27, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For each of these 3 could you remove the arguments in the docstring that are not valid. For example:

addons/tensorflow_addons/optimizers/cyclical_learning_rate.py

Line 156 in a519428

scale_fn: A function. Scheduling function applied in cycle

@lcsfrey
Copy link
Contributor Author

lcsfrey commented Feb 28, 2020

Woops, my bad. It's fixed!

seanpmorgan
seanpmorgan approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution to Addons! Failing test is unrelated.

@seanpmorgan seanpmorgan merged commit 78b0e6d into tensorflow:master Feb 28, 2020
@bot-of-gabrieldemarmiesse bot-of-gabrieldemarmiesse mentioned this pull request Feb 28, 2020
Merged
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@lcsfrey
Removed erroneous scale_fn from CLR subclasses (tensorflow#1160)
d4d2021 
* Removed erroneous scale_fn from CLR subclasses
* Updated CLR docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@Squadrick Squadrick Awaiting requested review from Squadrick

@WindQAQ WindQAQ Awaiting requested review from WindQAQ

Assignees

No one assigned

Labels

backport r0.8 Will backport any PR merged with this label to the r0.8 branch cla: yes optimizers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lcsfrey @seanpmorgan @googlebot