Skip to content

Fix label of macos version in wheels #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2020
Merged

Fix label of macos version in wheels #1119

merged 3 commits into from
Feb 21, 2020

Conversation

seanpmorgan
Copy link
Member

@seanpmorgan seanpmorgan commented Feb 21, 2020 •
edited
Loading

Closes #1108

@seanpmorgan seanpmorgan requested a review from a team as a code owner February 21, 2020 02:20
@boring-cyborg boring-cyborg bot added the github label Feb 21, 2020
@seanpmorgan seanpmorgan changed the title Fix labeled of macos wheels Fix label of macos version in wheels Feb 21, 2020
@seanpmorgan seanpmorgan added blocked Pending something elses completion and removed blocked Pending something elses completion labels Feb 21, 2020
@seanpmorgan seanpmorgan changed the title Fix label of macos version in wheels [WIP] Fix label of macos version in wheels Feb 21, 2020
@boring-cyborg boring-cyborg bot added the build label Feb 21, 2020
@seanpmorgan seanpmorgan changed the title [WIP] Fix label of macos version in wheels Fix label of macos version in wheels Feb 21, 2020
@seanpmorgan
Copy link
Member Author

@tensorflow/sig-addons-maintainers Fixed this. PTAL when time allows.

gabrieldemarmiesse
gabrieldemarmiesse approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, this should become easier to merge PRs like this once #1122 is fixed.

@gabrieldemarmiesse gabrieldemarmiesse merged commit f78818c into tensorflow:master Feb 21, 2020
@seanpmorgan seanpmorgan deleted the fix-mac-10-13 branch February 21, 2020 15:32
@gabrieldemarmiesse
Copy link
Member

Should this have been backported?

@seanpmorgan
Copy link
Member Author

Should this have been backported?

Ah yeah it should have. I think let's just make sure it works on today's nightly and then we can do it manually.

@gabrieldemarmiesse gabrieldemarmiesse added the backport r0.8 Will backport any PR merged with this label to the r0.8 branch label Feb 21, 2020
@bot-of-gabrieldemarmiesse bot-of-gabrieldemarmiesse mentioned this pull request Feb 21, 2020
Merged
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@seanpmorgan
Fix label of macos version in wheels (tensorflow#1119)
63fa309 
* Fix labeled of macos wheels

* Update plat version

* Fix string building
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees

No one assigned

Labels

backport r0.8 Will backport any PR merged with this label to the r0.8 branch build cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0.8.2, 0.8.1 version is not compatible with Mac OS version < 10.15

3 participants

@seanpmorgan @gabrieldemarmiesse @googlebot