Skip to content

Run workflow tests with different worker configs #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Run workflow tests with different worker configs #904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b499b1
Run workflow tests with different worker configs
dandavison Jun 18, 2025
8f62ca8
Add a worker config
dandavison Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/helpers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
UpdateMethodMultiParam,
)

DEFAULT_WORKER_KWARGS: dict[str, Any] = {}


def new_worker(
client: Client,
Expand All @@ -47,7 +49,7 @@ def new_worker(
workflow_runner=workflow_runner,
max_cached_workflows=max_cached_workflows,
workflow_failure_exception_types=workflow_failure_exception_types,
**kwargs,
**(DEFAULT_WORKER_KWARGS | kwargs),
)


Expand Down
41 changes: 41 additions & 0 deletions tests/worker/test_workflow_worker_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
"""
Run tests in test_workflow.py with different worker configurations.
"""

import inspect

import pytest

import tests.helpers
import tests.worker.test_workflow as test_workflow_module

_worker_configs = [
pytest.param(
{
"max_concurrent_workflow_tasks": 2,
"max_concurrent_workflow_task_polls": 2,
},
id="max_concurrent_workflow_tasks_2_polls_2",
),
pytest.param(
{
"max_concurrent_workflow_task_polls": 10,
"nonsticky_to_sticky_poll_ratio": 0.5,
},
id="max_concurrent_workflow_task_polls_10_nonsticky_to_sticky_poll_ratio_0.5",
),
]


@pytest.fixture(scope="module", autouse=True, params=_worker_configs)
def worker_config(request):
original_kwargs = tests.helpers.DEFAULT_WORKER_KWARGS.copy()
tests.helpers.DEFAULT_WORKER_KWARGS.update(request.param)
yield
tests.helpers.DEFAULT_WORKER_KWARGS.clear()
tests.helpers.DEFAULT_WORKER_KWARGS.update(original_kwargs)


for name, fn in inspect.getmembers(test_workflow_module, inspect.isfunction):
if name.startswith("test_"):
globals()[name] = fn
Loading