💥 Remove 'activity' from the model activity name #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Aug 21, 2025
There was a problem hiding this comment.
Mentioned off-PR, but this is a backwards-incompatible change. So we need product confirmation that we want to do this to save the 9 chars on activity type in UI, and if we do, we need a big 💥 on the PR description and a very clear release note that says past workflow runs are no longer valid w/ newer version (which we're within our rights to do since it's not GA yet).
Will leave approval pending this decision...
tconley1428
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changed
invoke_model_activitytoinvoke_model. This breaking change will cause workflows started on a previous version which use models to fail.Why?
activityclutters the UI with no additional information.Checklist
Closes
How was this tested: