This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Fix CLI is not disconnected on iOS exception #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
rosen-vladimirov
approved these changes
Nov 6, 2016
| for (let i = 0; i < packet.length - 2; i++) { | ||
| // The reply packages take the following form (the space in the reply templates is included for clarity) | ||
| // ‘S AA’ or ‘T AA n1:r1;n2:r2;...’ meaning that the program received signal number AA (a two-digit hexadecimal number) | ||
| for (let i = 0; i < packet.length - 3; i++) { | ||
| if (packet[i] === getCharacterCodePoint("$") && (packet[i + 1] === getCharacterCodePoint("T") || packet[i + 1] === getCharacterCodePoint("S"))) { |
There was a problem hiding this comment.
Can you move the values of $, T and S code points to a constants outside of the for as currently they are evaluated on each iteration
KristinaKoeva
force-pushed
the
KristinaKoeva/Exception
branch
from
5df41b1 to
815716f
Compare
|
❤️ |
The code used to read only the first digit, but according to the documentation the signal code is a two-digit hexadecimal number With the current version of the runtime the signal that is raised is SIGABRT == 0x06
KristinaKoeva
force-pushed
the
KristinaKoeva/Exception
branch
from
815716f to
e27c431
Compare
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used to read only the first digit, but according to the documentation the signal code is a two-digit hexadecimal number
With the current version of the runtime the signal that is raised is SIGABRT == 0x06
Fixes NativeScript/nativescript-cli#2053