Skip to content

Comand line Comparison not working if extension is not lowercase #63

@sebastianslutzky

Description

@sebastianslutzky

Steps to reproduce it

Run the following powershell command

&"C:\Program Files (x86)\Telerik\JustAssembly\Libraries\JustAssembly.CommandLineTool.exe" "E:\git\compare\current\content\lib\ikvm\JVM.DLL" "E:\git\compare\server\content\lib\ikvm\JVM.DLL" "JVM.DLLJVM.DLL.xml"

Expected Result

Assembly comparison should execute and succeed

Actual Result

Error with message
First assembly path is in incorrect format or file not found.
Exit code: 1

workaround:

lower casing the file extensions for both inputs worked well

&"C:\Program Files (x86)\Telerik\JustAssembly\Libraries\JustAssembly.CommandLineTool.exe" "E:\git\compare\current\content\lib\ikvm\JVM.dll" "E:\git\compare\server\content\lib\ikvm\JVM.dll" "JVM.DLLJVM.DLL.xml"

Possible cause:

This class:
https://github.com/telerik/JustAssembly/blob/master/UI/JustAssembly.CommandLineTool/FilePathValidater.cs#L30

should be validating the input file extensions regardless their casing. at the moment, only lowercase "dll" or "exe" are valid inputs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions