Skip to content

feat: release v1.4.1 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2020
Merged

feat: release v1.4.1 #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7094a2
chore: tweaks
technote-space Mar 3, 2020
08d5def
feat: update package version
technote-space Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions __tests__/misc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,19 @@ describe('getContext', () => {
describe('getContextArgs', () => {
testEnv();

it('should throw', async() => {
it('should throw 1', async() => {
process.env.INPUT_GITHUB_TOKEN = 'token';

await expect(getContextArgs(getGitHelper(), undefined, 'release/v1.2.3', '', {
await expect(getContextArgs(getGitHelper(), undefined, 'release/v1.2.3', '', undefined, {
owner: 'test-owner',
repo: 'test-repo',
})).rejects.toThrow('<tag> is required.');
});

it('should throw 2', async() => {
process.env.INPUT_GITHUB_TOKEN = 'token';

await expect(getContextArgs(getGitHelper(), undefined, 'release/v1.2.3', '', true, {
owner: 'test-owner',
repo: 'test-repo',
})).rejects.toThrow('<tag> is required.');
Expand All @@ -74,7 +83,7 @@ describe('getContextArgs', () => {
it('should get context args 1', async() => {
process.env.INPUT_GITHUB_TOKEN = 'token';

expect(await getContextArgs(getGitHelper(), 'v1.2.3', 'release/v1.2.3', '', {
expect(await getContextArgs(getGitHelper(), 'v1.2.3', 'release/v1.2.3', '', false, {
owner: 'test-owner',
repo: 'test-repo',
})).toEqual({
Expand All @@ -97,7 +106,7 @@ describe('getContextArgs', () => {
},
});

expect(await getContextArgs(getGitHelper(), '', 'release/v1.2.3', '', {
expect(await getContextArgs(getGitHelper(), '', 'release/v1.2.3', '', true, {
owner: 'test-owner',
repo: 'test-repo',
inputs: {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@technote-space/release-github-actions-cli",
"version": "1.4.0",
"version": "1.4.1",
"description": "Release GitHub Actions Cli",
"author": {
"name": "Technote",
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const execute = async(): Promise<void> => {
process.env.INPUT_GITHUB_TOKEN = token;
const helper = getGitHelper();
const config = getConfig(commander.package, commander.test);
const args = await getContextArgs(helper, commander.tag, commander.branch, commander.package, config);
const args = await getContextArgs(helper, commander.tag, commander.branch, commander.package, commander.test, config);

setEnv(config, commander.workspace);
if (!isValidContext(args)) {
Expand Down
4 changes: 2 additions & 2 deletions src/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ export const getRepository = (dir: string): { owner: string; repo: string } | ne
};
};

export const getContextArgs = async(helper: GitHelper, tagName: string | undefined, branch: string | undefined, dir: string, config: Config): Promise<ContextArgs> => {
export const getContextArgs = async(helper: GitHelper, tagName: string | undefined, branch: string | undefined, dir: string, isTest: boolean | undefined, config: Config): Promise<ContextArgs> => {
if (!tagName) {
if (!config.inputs?.TEST_TAG_PREFIX) {
if (!isTest || !config.inputs?.TEST_TAG_PREFIX) {
throw new Error('<tag> is required.');
}

Expand Down