Skip to content

Conversation

MaCleodWalker
Copy link
Contributor

No description provided.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Aug 12, 2025

🦋 Changeset detected

Latest commit: 07166d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 12, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
svelte-ux ✅ Ready (View Log) Visit Preview 07166d4

Copy link

pkg-pr-new bot commented Aug 12, 2025

Open in StackBlitz

npm i https://pkg.pr.new/svelte-ux@638

commit: 07166d4

Copy link
Owner

@techniq techniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @MaCleodWalker.

I do feel like there is a use case where you also don't want the selection modified as you are changing the "beforeOptions" filters (for example if you don't click on an option and just click away, the user probably assumes the state was unchanged, especially if the selection wouldn't be filtered by the active filtering(but could have been in the process).

That's going to be challenging to support and also reactively update when the options change AND you want them to update.

Regardless, this is a great change. Thanks!

@techniq techniq merged commit 06ccb84 into techniq:main Aug 12, 2025
4 checks passed
This was referenced Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants