update with fixes from main #65
Conversation
add swiss german language version
There was a problem hiding this comment.
Pull Request Overview
This PR merges fixes from the main branch into the current branch, adding Swiss German language support and improving the Italian language configuration. The changes include a new Swiss German word clock implementation, a fix for Italian language hour display logic, and enhancements to the main setup with WiFi configuration timeout.
- Added complete Swiss German language support for the word clock
- Fixed Italian language hour display logic for better accuracy
- Enhanced WiFi setup with configurable timeout for better reliability
- Updated README with improved formatting and documentation structure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| wordclockfunctions.ino_swiss | New Swiss German language implementation with time conversion and display functions |
| wordclockfunctions.ino_italian | Fixed hour display logic to simplify conditions for "E' L'" usage |
| wordclock_esp8266.ino | Added WiFi configuration portal timeout to prevent indefinite blocking |
| README.md | Restructured documentation with better formatting and comprehensive feature descriptions |
| { | ||
| hours -= 12; | ||
| } | ||
| if(minutes >= 25) //Sandro 20 |
There was a problem hiding this comment.
The comment '//Sandro 20' is unclear and doesn't explain the logic change. Consider adding a more descriptive comment explaining why the threshold was changed from 20 to 25 minutes.
| if(minutes >= 25) //Sandro 20 | |
| if(minutes >= 25) // Adjusted threshold from 20 to 25 minutes based on Sandro's suggestion to better align with Swiss German time conventions. |
Copilot uses AI. Check for mistakes.
| } | ||
| else if(minutes >= 20 && minutes < 25) | ||
| { | ||
| message += "ZWANZG AB "; //Sandro |
There was a problem hiding this comment.
The comment '//Sandro' doesn't provide meaningful information about the code. Consider removing it or replacing with a descriptive comment about the Swiss German terminology.
| message += "ZWANZG AB "; //Sandro | |
| message += "ZWANZG AB "; // "ZWANZG AB" means "twenty past" in Swiss German. |
Copilot uses AI. Check for mistakes.
| } | ||
| else if(minutes >= 40 && minutes < 45) | ||
| { | ||
| message += "ZWANZG VOR "; //Sandro |
There was a problem hiding this comment.
The comment '//Sandro' doesn't provide meaningful information about the code. Consider removing it or replacing with a descriptive comment about the Swiss German terminology.
| message += "ZWANZG VOR "; //Sandro | |
| message += "ZWANZG VOR "; // 'ZWANZG VOR' means 'twenty to' in Swiss German, indicating the time is twenty minutes before the next hour. |
Copilot uses AI. Check for mistakes.
| // //EIN(S) | ||
| // if(minutes > 4){ // Sandro | ||
| // message += "S"; | ||
| // } | ||
| // message += " "; |
There was a problem hiding this comment.
There is commented-out code that should be removed if it's no longer needed, or uncommented if it serves a purpose. This reduces code clarity and maintainability.
| // //EIN(S) | |
| // if(minutes > 4){ // Sandro | |
| // message += "S"; | |
| // } | |
| // message += " "; |
Copilot uses AI. Check for mistakes.
1 participant
No description provided.