Skip to content

Conversation

tdgroot
Copy link
Owner

@tdgroot tdgroot commented Mar 29, 2018

Description

When instantiating a model the following:

<?php
$inquiry = $this->inquiryFactory->create(['data' => $data]);
$this->inquiryResource->save($inquiry);

The model won't be saved, because when instantiating a model with data, _hasDataChanges won't be set to true. That's because currently, it's the responsibility of AbstractModel::setData().

Manual testing scenarios

  1. Create a model using a factory, provided with data
  2. Save the model

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@tdgroot tdgroot closed this Mar 29, 2018
tdgroot pushed a commit that referenced this pull request Oct 31, 2018
tdgroot pushed a commit that referenced this pull request Nov 1, 2018
tdgroot pushed a commit that referenced this pull request Nov 1, 2018
tdgroot pushed a commit that referenced this pull request Nov 1, 2018
[Backport] Use route ID when creating secret keys in backend menus instead of route name
tdgroot pushed a commit that referenced this pull request Nov 1, 2018
tdgroot pushed a commit that referenced this pull request Nov 1, 2018
Fixed issues-18534: 2 wysiwyg on catalog category edit page
tdgroot pushed a commit that referenced this pull request Nov 9, 2018
Remove unnecesary "header" block redeclaration
tdgroot pushed a commit that referenced this pull request Nov 9, 2018
engcom-Charlie pushed a commit that referenced this pull request Aug 13, 2020
Merge changes from origin repo
tdgroot pushed a commit that referenced this pull request Oct 8, 2021
…rateCustomerToken

Fixed the not expiry of token in generateCustomerToken graphql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant