Fixes for #2 and #4 #3
Open
+248,251
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, causing random failures in decompression of such data.
Author
|
Fixed a bug in the vendor base 64 implementation, to resolve #4 |
karlr42
changed the title
Owner
|
Hi, Karlr42. Thanks for you pull-request, but to make sure that it works, I need that you modify the U.T. to add the new case to check that it works as expected. |
Author
|
Ok, I am trying. But I have never used any of these JS unit testing libraries so I don't really know what I am doing. |
Author
|
Done. I had to change the Karma test to use Chrome because PhantomJS's JSON.parse was failing for long strings. I don't have any more time to spend on this project so up to you what you want to do. |
Alamantus
added a commit
to Alamantus/JSON-Compress
that referenced
this pull request
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a RangeError is thrown when calling apply() in JSONC.unzip, use a loop instead. This should fix problems with exceeding the maximum call size- fix for #2.