Skip to content

Conversation

@pewsheen
Copy link
Contributor

@pewsheen pewsheen commented Mar 18, 2024

What kind of changes does this PR include?

  • New or updated content
    • Update features/updater page

Description

@pewsheen pewsheen requested a review from a team as a code owner March 18, 2024 06:11
@netlify
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 297ec8a
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65fb011ef571c00008d998f9
😎 Deploy Preview https://deploy-preview-1968--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pewsheen pewsheen marked this pull request as draft March 18, 2024 06:12
@pewsheen pewsheen marked this pull request as ready for review March 18, 2024 06:15
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing i don't know where to add is a note about that you have to choose between msi and nsis for the updater to work correctly. maybe also showing how?

(maybe also adding a note somewhere that you can update from msi to nsis if nsis is and stays in perMachine mode idk)

@pewsheen
Copy link
Contributor Author

pewsheen commented Mar 18, 2024

One thing i don't know where to add is a note about that you have to choose between msi and nsis for the updater to work correctly. maybe also showing how?

(maybe also adding a note somewhere that you can update from msi to nsis if nsis is and stays in perMachine mode idk)

Do you have any reference or discussion or example (maybe?) about this?

The server side needs to return only one of the bundler (.nsis or .msi)?

@FabianLars
Copy link
Member

Do you have any reference or discussion or example (maybe?) about this?

Hmm, not really no.

Basically the problem here is that if a user installed the app via the nsis exe then the updater artifact must also be the nsis exe (==the zip with it inside). Same for the .msi

The updater however only differentiates between the OS and arch, but not the package type, and there's currently no easy way to know how an app was installed either so devs can't really polyfill this themselves.

@pewsheen
Copy link
Contributor Author

Do you have any reference or discussion or example (maybe?) about this?

Hmm, not really no.

Basically the problem here is that if a user installed the app via the nsis exe then the updater artifact must also be the nsis exe (==the zip with it inside). Same for the .msi

The updater however only differentiates between the OS and arch, but not the package type, and there's currently no easy way to know how an app was installed either so devs can't really polyfill this themselves.

Thanks for the explanation! I think I'll add this as a note to the Server Support section, so the static JSON and dynamic response should be aware of this.

@FabianLars FabianLars merged commit 4e6dd50 into tauri-apps:next Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Create Updater guide

3 participants