Skip to content

Conversation

Lancetnik
Copy link
Collaborator

No description provided.

joshpaulchan and others added 6 commits October 12, 2025 15:11
Since Taskiq-faststream should officially support `faststream 0.6.0`, I'm hoping to update the dependencies here so that installation requirements are satisfiable.
Update faststream dependency version range to <=0.6.0
@Lancetnik Lancetnik merged commit 6c67e01 into master Oct 13, 2025
5 checks passed
@RK-goldengate-co
Copy link

Code Review - PR #112: 0.3.1

Summary: ✅ Clean version release with good modernization

Positive aspects:

  1. Version bump: 0.3.0 → 0.3.1 properly versioned
  2. Dependency update: Updated faststream from <0.6.0 to <0.7 allowing use of newer versions
  3. Python version upgrade:
    • Dropped Python 3.9 support (minimum now 3.10)
    • Updated mypy and ruff configs accordingly
  4. Type annotation modernization: Embraced PEP 604 union syntax:
    • Union[A, B]A | B (cleaner, more readable)
    • Optional[X]X | None (explicit nullability)
    • Moved TypeAlias from typing_extensions to typing (now standard in 3.10+)
  5. Multiple contributors: Good collaboration between joshpaulchan (faststream update) and Lancetnik (linting + modernization)
  6. Clean merge workflow: develop → master with proper branch management

Code quality highlights:

  • Consistent modernization across all affected files
  • Follows modern Python best practices (PEP 604)
  • Linting applied via ruff to ensure code quality
  • All 8 CI checks passed

Files changed:

  • pyproject.toml (version + dependency updates)
  • setup.py (same updates)
  • ruff.toml (Python 3.10 target)
  • mypy.ini (Python 3.10 target)
  • broker.py (type annotations modernized)
  • state.py (type annotations modernized)

Minor observation:
No PR description - Consider adding release notes detailing:

  • Breaking change: Python 3.9 support dropped
  • Dependency compatibility: faststream <0.7 now supported
  • Type annotation improvements

Security & Maintainability: ✅ Excellent - modernizing type hints improves code clarity and IDE support

Overall assessment: Great release! This PR properly modernizes the codebase for Python 3.10+, updates dependencies to support newer faststream versions, and improves type annotations. The lack of a description is the only minor issue. LGTM! 🎉🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants