Rework server log handling #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locker
force-pushed
the
server-log-rework
branch
from
b73db1f to
7536175
Compare
Compatibility with CMake < 3.5 has been removed from CMake.
locker
force-pushed
the
server-log-rework
branch
from
7536175 to
701063e
Compare
Otherwise we can get mixed logs in the unified log file after running luatest a few times. No changelog because the feature was added by commit f8a1c10 ("Add logging to unified file"), which hasn't been released yet.
locker
force-pushed
the
server-log-rework
branch
from
701063e to
975dac0
Compare
Instead of configuring Tarantool test servers to write logs both to stdout and a file using the tee command, let's write all logs to stderr only and make the output beautifier work as tee. This fixes two issues at once: - Using `grep_log()` for a server started using the `cluster` helper. - Using `grep_log()` for a stopped server. Note that after this change we don't store all stderr output in the output beautifier anymore. It was used for detecting crashes at exit. Now, we use `grep_log()` to search for segmeration faults and memory leaks. Closes tarantool#389 Closes tarantool#397
locker
force-pushed
the
server-log-rework
branch
from
975dac0 to
be2c0c4
Compare
If unified logging is enabled, logs written by the runner are written both to its own log file and to the unified log file. This is consistent with how logs written by test processes are handled. However, if unified logging is disabled, then runner logs are written only to its log file while test process logs are also written to stdout and captured if capturing is enabled. Let's write runner logs to stdout in this case as well because they can be useful for debugging. While we are at it, let's get rid of using `tee` for logging: we can redirect all logs to the output beautifier directly and instruct the latter to write them to a file. No changelog because the feature was added by commit f8a1c10 ("Add logging to unified file"), which hasn't been released yet.
locker
force-pushed
the
server-log-rework
branch
from
1a77a5e to
c1d5324
Compare
Totktonada
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of configuring Tarantool test servers to write logs both to stdout and a file using the tee command, let's write all logs to stderr only and make the output beautifier work as tee. This fixes two issues at once:
grep_log()for a server started using theclusterhelper.grep_log()for a stopped server.Note that after this change we don't store all stderr output in the output beautifier anymore. It was used for detecting crashes at exit. Now, we use
grep_log()to search for segmeration faults and memory leaks.Closes #389
Closes #397