Remove redundant URI path segment check in parse_request #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase with master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit proposes the removal of a redundant URI path segment check within the
parse_requestfunction.Currently, the code contains a loop that iterates over each path segment in the parsed URI, checking for the presence of
.or..segments. However, this check is unnecessary since HTTP requests with/./or/../in the URI are automatically corrected by the http server, converting them into//which is the expected behavior.The primary reason for removing this check is to address an issue detailed in the GitHub pull request #173. In cases where Tarantool decodes a request like
.%2F.html.%2Fto./.html./, the current code implementation throws aninvalid urierror. However, this behavior is not desired. Instead, it is expected to return the URI as is.