-
Notifications
You must be signed in to change notification settings - Fork 43
3.0 new iproto format #3947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
3.0 new iproto format #3947
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f03a7bd
3.0 new iproto format: single instance
andreyaksenov fd5d283
3.0 new iproto format: manual leader
andreyaksenov 2428fdd
3.0 new iproto format: auto leader
andreyaksenov 2650310
3.0 new iproto format: master master
andreyaksenov b0cd943
3.0 new iproto format: bootstrap strategy
andreyaksenov ed3a3af
3.0 new iproto format: replication peers
andreyaksenov f7537ac
3.0 new iproto format: sharding (fix + update)
andreyaksenov 59fb2fe
3.0 new iproto format: reference
andreyaksenov d9870b4
3.0 new iproto format: review fixes 1
andreyaksenov 880612b
3.0 new iproto format: review fixes 2
andreyaksenov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,5 @@ groups: | |
instances: | ||
instance001: | ||
iproto: | ||
listen: "3301" | ||
listen: | ||
- uri: '127.0.0.1:3301' |
5 changes: 3 additions & 2 deletions
5
doc/code_snippets/snippets/config/instances.enabled/global_scope/config.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
iproto: | ||
listen: "3301" | ||
listen: | ||
- uri: '127.0.0.1:3301' | ||
|
||
groups: | ||
group001: | ||
replicasets: | ||
replicaset001: | ||
instances: | ||
instance001: {} | ||
instance001: { } |
5 changes: 3 additions & 2 deletions
5
doc/code_snippets/snippets/config/instances.enabled/group_scope/config.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
groups: | ||
group001: | ||
iproto: | ||
listen: "3301" | ||
listen: | ||
- uri: '127.0.0.1:3301' | ||
replicasets: | ||
replicaset001: | ||
instances: | ||
instance001: {} | ||
instance001: { } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,5 @@ groups: | |
instances: | ||
instance001: | ||
iproto: | ||
listen: "3301" | ||
listen: | ||
- uri: '127.0.0.1:3301' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
doc/code_snippets/snippets/sharding/templates/basic/{{.name}}-scm-1.rockspec.tt.template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
package = '{{ .name }}' | ||
version = 'scm-1' | ||
source = { | ||
url = '/dev/null', | ||
} | ||
|
||
dependencies = { | ||
'vshard == 0.1.25' | ||
} | ||
build = { | ||
type = 'none'; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I can see, the latest
vshard
version is 0.1.24. Suppose,tt rocks make
will not work with this rockspec until 0.1.25 is out.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Totktonada Am I correct that the latest config should work with vshard 0.1.25 only? If the new version will be released at the same time as 3.0.0, keeping the new vshard option in the doc sample should be OK. Otherwise, don't know what decision is the best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPD: see also https://github.com/tarantool/tarantool/pull/9533/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vshard was released today. It was carefully planned :)