Skip to content

Conversation

tanyasmirnova
Copy link
Owner

The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).

Enter a description of this PR. This should include why this PR was created, and what it does.

Testing and relations to other Pull Requests should be added as subsequent comments.

See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931

Information on running mandatory regression tests on Jet can be found here and the results pasted below.

regression test case results
PASTE compare_run_testcases AND/OR compare_create_testcases TEXT HERE

tanyasmirnova and others added 8 commits January 13, 2025 21:28
In the modified code, soil resistance can completely turn off the
evaporation with values of soil moisture close to minimum values.
Thus, this change will help with moist bias in MPAS in the dry regions.
1. Created a new directory: physics_lsm_ruc
2. Moved RUC LSM subroutines to the new directory
3. Removed RUC LSM subroutines from physics_wrf.
4. Updated Makefiles in physics and physics_wrf directories.
The new code compiled successfully.
* * Adds flag to control freezing rain output from TEMPO, config_tempo_fzra
 * Adds accumulated freezing rain variable, frainnc

* Adds freezing rain pointer, frainnc_p to variable list

* Bugfix for freezing rain pointer: removed trailing comma and ampersand for variable definition

* * Adds allocation/deallocation controls for freezing rain pointer (frainnc_p) by config_tempo_fzra

 * Adds allocatable freezing rain variable to TEMPO driver

* Separate case options for TEMPO and NSSL microphysics for precip_to_MPAS and MPAS_to_precip

* Initialization and calculation of freezing rain (frainnc) for diag_physics

* Update pointer to TEMPO for freezing rain feature

* Update TEMPO pointer

* turn on TEMPO freezing rain flag by default

* Update TEMPO pointer

* clean up freezing rain code and remove registry flag

* Update TEMPO pointer

* update pointer to TEMPO

* Update version and add TEMPO table build executable to gitignore

* Update to NCAR version of TEMPO
…d with RUC ice model. (ufs-community#97)

* Switch to using flux method in RUC LSM 2-m diagnostics.

* The version is changed to 8.2.2-2.5

* mpas_atmphys_driver_seaice.F
1. Fix the bug that crashes MPAS when frac_seaice=false. Use
   'if(config_frac_seaice) then' around arrays with *_sea that are
   allocated only when config_frac_seaice=true. This bug is reported to
   Michael Duda.
2. Add flqc and flhc computation for fractional ice. These variables are
   used in RUC ice module and are needed for reproducibility over sea ice.

* mpas_atmphys_driver_sfclayer.F:
1. Do not deallocate flqc_sea and flhc_sea - they are used later in
   the seaice driver.

* mpas_atmphys_driver_sfclayer.F: do not compine sea and ice values when
xice=1. It will reduce computations over solid sea ice (Arctic).

* Skip aggreagation of sea and ice values when xice=1.
CPM is not RUC-specific variable, moved out of sf_ruc IF.

* Added definition of flhc and flqc for RUC LSM.

* Deleted excutables.

* Added a blank line.

* removed local files.

* Set targetcell to 0, this will turn off debug printing.

* Modify version to v8.2.2-2.8

* The version is changed to v8.2.2-2.8.

* mpas_atmphys_driver_seaice.F: reset water background albedo to sea ice
background albedo when water is frozen.

* Now I got the sfc_albbck updated correctly.

* Sfc_albbck and config_frac_seaice definitions are moved to different
lines for easy merge with NCAR code.

* mpas_atmphys_driver_lsm.F
In the LSM driver frpcpn = false. If it is false, frozen precipitation
in RUC and Noah LSMs is computed using temperature threshold and ignoring the
information from the microphysics scheme.
A new parameter frpcpn_ruc is introduced for use with RUC LSM, and it is set
to true. This change will use the microphysics information correctly
and will fix the problem with the run-total accumulation of snow depth.

* Revert the previous change, it should not be in seaice_fix branch.

* Deleted atmosphere_model.v8.2.2-2.8.intdebug

* Restore top of TEMPO.
…re tendency change (ufs-community#98)

* Update to MYNN-EDMF to add re-indexed arrays and temperature tendency change

* Updating pointer to MYNN-EDMF, with bug fix for re-indexing

* Updating pointer to MYNN-EDMF with MF updates and new 2d diagnostics

* bug fix for pbl driver

* updating MYNN-EDMF pointer to use bl_mynn_edmf_dd as namelist option

* updating versioning

* updating version for init
…fs-community#104)

* Switch to using flux method in RUC LSM 2-m diagnostics.

* The version is changed to 8.2.2-2.5

* mpas_atmphys_driver_seaice.F
1. Fix the bug that crashes MPAS when frac_seaice=false. Use
   'if(config_frac_seaice) then' around arrays with *_sea that are
   allocated only when config_frac_seaice=true. This bug is reported to
   Michael Duda.
2. Add flqc and flhc computation for fractional ice. These variables are
   used in RUC ice module and are needed for reproducibility over sea ice.

* mpas_atmphys_driver_sfclayer.F:
1. Do not deallocate flqc_sea and flhc_sea - they are used later in
   the seaice driver.

* mpas_atmphys_driver_sfclayer.F: do not compine sea and ice values when
xice=1. It will reduce computations over solid sea ice (Arctic).

* Skip aggreagation of sea and ice values when xice=1.
CPM is not RUC-specific variable, moved out of sf_ruc IF.

* Added definition of flhc and flqc for RUC LSM.

* Deleted excutables.

* Added a blank line.

* removed local files.

* Set targetcell to 0, this will turn off debug printing.

* Modify version to v8.2.2-2.8

* The version is changed to v8.2.2-2.8.

* mpas_atmphys_driver_seaice.F: reset water background albedo to sea ice
background albedo when water is frozen.

* Now I got the sfc_albbck updated correctly.

* Sfc_albbck and config_frac_seaice definitions are moved to different
lines for easy merge with NCAR code.

* mpas_atmphys_driver_lsm.F
In the LSM driver frpcpn = false. If it is false, frozen precipitation
in RUC and Noah LSMs is computed using temperature threshold and ignoring the
information from the microphysics scheme.
A new parameter frpcpn_ruc is introduced for use with RUC LSM, and it is set
to true. This change will use the microphysics information correctly
and will fix the problem with the run-total accumulation of snow depth.

* Removed atmosphere_model.v8.2.2-2.8.intdebug

* Change cersion to 8.2.2-2.10

* Added comment

* fix spacing to match authoritative

---------

Co-authored-by: jderrico-noaa <[email protected]>
…#105)

* Removed land/water masking in snow interpolation. This fix is needed to
preserve initialized from GFS snow on sea ice.
If some water points will get snow after horizontal interpolation, it
will be cleaned out later in the model.

* Limit snow depth on sea ice to 40 cm (120 mm SWE).

* In mpas_atmphys_initialize_real.F increase the limit of snow on ice to
1.2 m

* Version is changed to 8.2.2-2.11

---------

Co-authored-by: Janet Derrico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants