Fix rending of group role. Add unit test and demo #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
role 'group' add to list wrap Add unit test to aria roles and states.
Add demo using aria Working demo for aria
Merge upstream changes
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=========================================
+ Coverage 92.16% 92.77% +0.6%
=========================================
Files 1 1
Lines 166 166
=========================================
+ Hits 153 154 +1
+ Misses 13 12 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group role wasn't being render. Update render function to correct this.
Added unit test to make sure aria attributes are rendering.
Add a Demo using wia-aria for a list. demo/vfor-mode-with-aria