Skip to content

Remove unnecessary padding bottom when decimal number is used #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2019
Merged

Remove unnecessary padding bottom when decimal number is used #90

merged 1 commit into from
Mar 3, 2019

Conversation

andriepu
Copy link
Contributor

@andriepu andriepu commented Mar 2, 2019 •
edited
Loading

When we are defining remain value via containerHeight / size (because the containerHeight is a fixed value), it can lead us to have decimal value on remain variable.

Because of it, we will have this extra padding shown by gif below:

In the case above, I use 6.6 as the value of remain.

@tangbc tangbc merged commit 7343f19 into tangbc:master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andriepu @tangbc