Skip to content

Conversation

scarry1992
Copy link
Contributor

Please, accept this PR, or it better:)
Related with #144

@codecov-io
Copy link

Codecov Report

Merging #165 into master will decrease coverage by 0.34%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   92.76%   92.41%   -0.35%     
==========================================
  Files           1        1              
  Lines         221      224       +3     
==========================================
+ Hits          205      207       +2     
- Misses         16       17       +1
Impacted Files Coverage Δ
src/index.js 92.41% <66.66%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc2aa3...3b2cb51. Read the comment docs.

@tangbc tangbc merged commit 3b2cb51 into tangbc:master Feb 17, 2020
Copy link

@vkhikhlov vkhikhlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix causes problems when delta.total == 0

end = start + delta.keeps - 1;

if (end > delta.total) {
end = delta.total - 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't work properly when delta.total == 0

Copy link
Owner

@tangbc tangbc Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in version 1.4.6

tangbc added a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants